Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for me together with Quafzi's plugin #1

Closed
wigman opened this issue Jul 8, 2015 · 7 comments
Closed

Not working for me together with Quafzi's plugin #1

wigman opened this issue Jul 8, 2015 · 7 comments

Comments

@wigman
Copy link

wigman commented Jul 8, 2015

I'm confused. The readme states this should be used in conjunction with Quafzi_PerformanceTweaks.
BUT, your plugin seems to depend on the default recently viewed function which is disabled by these event overrides in Quafzi's config:

  <controller_action_predispatch>
    <observers>
      <log>
        <type>disabled</type>
      </log>
    </observers>
  </controller_action_predispatch>
  <controller_action_postdispatch>
    <observers>
      <log>
        <type>disabled</type>
      </log>
    </observers>
  </controller_action_postdispatch>

  <catalog_controller_product_view>
    <observers>
      <reports>
        <type>disabled</type>
      </reports>
    </observers>
  </catalog_controller_product_view>

When I uncomment these three, your module works. Otherwise: no banana's.

The whole point was to disable the log-writes because it crashes my server once in a while.

Am I totally missing something related to a plugin I've installed, or did I misunderstand the functionalities of this module?

Thanks!

@philwinkle
Copy link
Contributor

Great, yes, sorry. This needs to be updated with the final version which removed the requirement.

Apologies and thanks. Will get right on this.

On Jul 8, 2015 10:57 AM, Willem Wigman notifications@github.com wrote:

I'm confused. The readme states this should be used in conjunction with Quafzi_PerformanceTweaks.
BUT, your plugin seems to depend on the default recently viewed function which is disabled by these event overrides in Quafzi's config:

<controller_action_predispatch>


disabled


</controller_action_predispatch>
<controller_action_postdispatch>


disabled


</controller_action_postdispatch>

<catalog_controller_product_view>


disabled


</catalog_controller_product_view>

When I uncomment these three, your module works. Otherwise: no banana's.

The whole point was to disable the log-writes because it crashes my server once in a while.

Am I totally missing something related to a plugin I've installed, or did I misunderstand the functionalities of this module?

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//issues/1.

@wigman
Copy link
Author

wigman commented Jul 8, 2015

Okay, great! Thanks:)

@wigman
Copy link
Author

wigman commented Jul 9, 2015

Dit you manage to make any progress on this yesterday? :)

@philwinkle
Copy link
Contributor

Getting eyes on this today. Sorry for the delay!

From: Willem Wigman [mailto:notifications@github.com]
Sent: Thursday, July 09, 2015 3:56 AM
To: sdinteractive/SomethingDigital_RecentlyViewed
Cc: Phillip Jackson
Subject: Re: [SomethingDigital_RecentlyViewed] Not working for me together with Quafzi's plugin (#1)

Dit you manage to make any progress on this yesterday? :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-119862502.

@philwinkle
Copy link
Contributor

@wigman Please re-test. This should be good to go.

@wigman
Copy link
Author

wigman commented Jul 18, 2015

Okay, thanks!

@wigman
Copy link
Author

wigman commented Jul 18, 2015

It works. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants