Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pendulum.test to properly unwind after an exception #445

Merged
merged 1 commit into from Mar 6, 2020

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Mar 5, 2020

Previously, if an exception occurred inside a 'with pendulum.test(...)'
block, then the monkeypatch would remain in place instead of being
un-done. This could cause confusing results, as one failing test could
cause other tests to run with an unexpected mock in place and cause
other failures.

Previously, if an exception occurred inside a 'with pendulum.test(...)'
block, then the monkeypatch would remain in place instead of being
un-done. This could cause confusing results, as one failing test could
cause other tests to run with an unexpected mock in place and cause
other failures.
@njsmith njsmith force-pushed the test-unwind-after-error branch from 2c11502 to 0b4f34e Compare Mar 5, 2020
@njsmith
Copy link
Contributor Author

njsmith commented Mar 5, 2020

All the test failures appear to be unrelated.

@sdispater sdispater merged commit 8839568 into sdispater:master Mar 6, 2020
1 check failed
@sdispater
Copy link
Owner

sdispater commented Mar 6, 2020

Thanks!

@sdispater sdispater mentioned this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants