Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long_description_content_type to sdist setup kwargs #1166

Conversation

steinnes
Copy link

This PR attempts to add the content type of long_description to setup.py kwargs when building sdists.

I noticed that the content type is included in the wheel metadata, but missing from the setup() call in sdist packages.

I did not update any documentation as part of this pull request, because I do not believe this is a change/feature requiring documentation, rather a minor bugfix.

@brycedrennan
Copy link
Contributor

Thanks for contributing! Would you be able to rebase this into one commit?

@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 16, 2019
@steinnes
Copy link
Author

Yes certainly :-)

@steinnes steinnes force-pushed the include-long-desc-content-type-in-sdist branch from 8c359f6 to 79af8cc Compare August 17, 2019 17:50
@steinnes steinnes force-pushed the include-long-desc-content-type-in-sdist branch from 79af8cc to c3d7706 Compare October 21, 2019 21:54
@mbargull
Copy link

We just encountered this behavior too.
@brycedrennan, is there anything else to be done here before this can be merged?
(cc @tedil)

@neersighted neersighted self-assigned this Nov 11, 2021
@neersighted
Copy link
Member

Superseded by #1994

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants