Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding extras to android runtime #738

Merged
merged 15 commits into from
Nov 8, 2022
Merged

Adding extras to android runtime #738

merged 15 commits into from
Nov 8, 2022

Conversation

manoellribeiro
Copy link
Contributor

I made something similar to what we already had on the browser-runtime, that is the possibility to send an map called extras in every request, but in the android-runtime the difference is that we have two concepts of "extras":

  • globalExtra: This one will be passed to every request and should be passed in the constructor of the client.
  • requestExtra: This one can be passed in just one request if the user wants to do so and should be passed as parameter in the request method.

manoellribeiro and others added 11 commits September 24, 2021 14:26
@manoellribeiro
feat: add the possibility of not using callbacks on endpoint methods
f88e26f
@manoellribeiro
feat: use readline to ask the user if should implement callbacks on e…
8a1ef77 
…ndpoint methods
@manoellribeiro
refactor: stop to use readline and create kotlin_android_without_call…
94805f3 
…backs target
@manoellribeiro
style: fix lint errors on build.ts of cli folder and android-client.ts
e2ebfad
@manoellribeiro
Merge branch 'sdkgen:master' into master
537be5c
@manoellribeiro
feat: add the possibility of setting the fingerprint manually
b8eebad
@manoellribeiro
feat: generate ApiClient class with fingerprint as optional construct…
357a032 
…or parameter
@manoellribeiro
fix: add @rawvalue annotation on JsonElement type to prevent build er…
f191bf1 
…rors
@manoellribeiro
Merge branch 'sdkgen:master' into master
a7ba4dc
@manoellribeiro
feat: add global and request extras to SdkgenHttpClient
cc3fe0a
@manoellribeiro
feat: generate kotlin client with global and request extras
a8b9e82
danielpsantiago
danielpsantiago previously approved these changes Nov 2, 2022
View reviewed changes
@dgadelha dgadelha merged commit ff152a1 into sdkgen:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbguilherme lbguilherme lbguilherme approved these changes

@dgadelha dgadelha dgadelha approved these changes

@danielpsantiago danielpsantiago danielpsantiago left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manoellribeiro @lbguilherme @dgadelha @danielpsantiago