bookmark endpoints #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2020 00:30
this feature allows the user to bookmark endpoints, displaying those endpoints on top of all other endpoints. the status of bookmarked is persisted on localstorage.
lbguilherme
reviewed
Oct 4, 2020
|
|
||
| export function setLocalStorageBookmarks(names: string[]) { | ||
| localStorage.setItem(BOOKMARK_LOCALSTORAGE_KEY, JSON.stringify(names)); | ||
| } |
There was a problem hiding this comment.
This will have some issues with browsers limiting local storage, such as lack of space of Safari's icognito mode. Better check that localStorage is actually working and guard it with a try catch, falling back to memory: https://michalzalecki.com/why-using-localStorage-directly-is-a-bad-idea/
lbguilherme
previously approved these changes
Oct 5, 2020
|
This branch now has conflicts. Can you take a look? |
|
for sure! |
…avorite-endpoints
lbguilherme
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this feature allows the user to bookmark endpoints, displaying those endpoints on top of all other endpoints. the status of bookmarked is persisted on localStorage.
Screenshots
no bookmarks
with bookmarks
