Add new candidate for Micronaut #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We won't have the 1.0.0.M1 release for another month or so, however I just wanted to get this in place.
marc0der
requested changes
Apr 26, 2018
| Candidate( | ||
| candidate = "micronaut", | ||
| name = "Micronaut", | ||
| description = "Micronaut is an open source microservice framework for the JVM", |
There was a problem hiding this comment.
Can we be a bit more elaborate with the description? This is what will appear on the sdks page of our site, as well as when you do an sdk ls on the command line.
There was a problem hiding this comment.
@marc0der Thank you for letting me know. I wasn't aware of that. I'll update it
| default = "1.0.0.M1", | ||
| websiteUrl = "http://micronaut.io/", | ||
| distribution = "UNIVERSAL")) | ||
| } |
There was a problem hiding this comment.
We will also need an insertVersion() to fulfill the initial candidate creation.
|
I've done some changes in the SDKMAN backend that will now allow for a candidate to exist without setting a default version. I've subsequently updated your PR and it has now been merged so closing this PR (somehow github seems confused about this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We won't have the 1.0.0.M1 release for another month or so, however I just wanted to get this in place.