Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement of region and entity xpm comment tags #64

Open
HaraldHoffelinck opened this issue Sep 20, 2016 · 3 comments
Open

Placement of region and entity xpm comment tags #64

HaraldHoffelinck opened this issue Sep 20, 2016 · 3 comments

Comments

@HaraldHoffelinck
Copy link
Contributor

HaraldHoffelinck commented Sep 20, 2016

Currently, DXA outputs the region and entity XPM comment tags (<!-- start region & <!-- start componentpresentation) below the first HTML element of the region or entity view.

Sometimes, it could be useful if the developer could specify that these comments should start on a different tag, where the $markup.entity() & $markup.region() attributes are outputted for example.

@rpannekoek
Copy link
Contributor

Can you elaborate on use cases where you don't want the XPM markup directly inside the top-level HTML element rendered by the Region/Entity View?

@HaraldHoffelinck
Copy link
Contributor Author

One of the issues we are seeing in our implementation is that the xpm boxes that indicate the zone of a region or an editable entity sometimes overlap, or run outside of the visible window, due to the html design. By allowing the developer to put the xpm markup in a lower level element, we have more control of where the xpm boxes are shown.

We have made some tweaks to the markup functions and the xpm decorator that allow this functionality, I'm preparing a pull request for this.

@rpannekoek
Copy link
Contributor

TSI-2005 (internal issue ID for tracking purposes)

@rpannekoek rpannekoek removed this from the v1.7 milestone Oct 19, 2016
rpannekoek pushed a commit that referenced this issue Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants