-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement of region and entity xpm comment tags #64
Comments
Can you elaborate on use cases where you don't want the XPM markup directly inside the top-level HTML element rendered by the Region/Entity View? |
One of the issues we are seeing in our implementation is that the xpm boxes that indicate the zone of a region or an editable entity sometimes overlap, or run outside of the visible window, due to the html design. By allowing the developer to put the xpm markup in a lower level element, we have more control of where the xpm boxes are shown. We have made some tweaks to the markup functions and the xpm decorator that allow this functionality, I'm preparing a pull request for this. |
TSI-2005 (internal issue ID for tracking purposes) |
…ect which implements the Page interface
Currently, DXA outputs the region and entity XPM comment tags (
<!-- start region
&<!-- start componentpresentation
) below the first HTML element of the region or entity view.Sometimes, it could be useful if the developer could specify that these comments should start on a different tag, where the
$markup.entity()
&$markup.region()
attributes are outputted for example.The text was updated successfully, but these errors were encountered: