New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment of annotations #38

Closed
sosna opened this Issue Feb 4, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@sosna
Member

sosna commented Feb 4, 2016

Issue received on the SDMX users forum:

"In the spec, there is an annotations array, this array can contain multiple annotations,

In sdmx-ml, annotations can be attached to either dataset, series or observation,

In sdmx-json is the fact that an annotation attached to an observation lost in the translation from sdmx-ml to sdmx-json? I can't see any way to put in the sdmx-json that the annotation is attached to an observation ?? all the annotations are grouped together in the array with no field on the observation to denote that a particular annotation is associated with that observation ?

Thanks in advance for clearing things up for me.."

@dosse

This comment has been minimized.

Contributor

dosse commented Jul 21, 2017

I discussed this briefly with Matt, The best approach seems being to complete the SDMX-JSON standard documentation by extending the definition of the arrays in the observations object to include also annotation indexes in addition to the observation values and the attribute indexes.

dosse added a commit that referenced this issue Jul 28, 2017

Update 1-sdmx-json-field-guide.md
Include changes for issue #38 for attachment of annotations to observations, components and component values

dosse added a commit that referenced this issue Aug 11, 2017

Update 1-sdmx-json-field-guide.md
Implemented agreed improvement related to issue #38: Highlight sentence explaining the constraint for positions of attributes when including annotations for observations.

dosse added a commit that referenced this issue Aug 29, 2017

Update 1-sdmx-json-field-guide.md
Updated inline examples with annotations for issue #38. Complemented/corrected descriptions related to annotations.

dosse added a commit that referenced this issue Aug 29, 2017

Update 3-full-example-with-comments.md
Updates for issue #38 "Attachment of annotations"

dosse added a commit that referenced this issue Aug 29, 2017

Update sdmx-json-data-schema.json
Updated schema for issue #38 (Attachment of annotations)

dosse added a commit that referenced this issue Aug 29, 2017

Update exr-cross-section.json
Updated example for issue #38 (Attachment of annotations)

dosse added a commit that referenced this issue Aug 29, 2017

Update exr-flat.json
Updated example for issue #38 (Attachment of annotations)

dosse added a commit that referenced this issue Aug 29, 2017

Update exr-time-series.json
Updated example for issue #38 (Attachment of annotations)
@dosse

This comment has been minimized.

Contributor

dosse commented Aug 29, 2017

As agreed by SDMX-TWG TF3, added support for attachment of annotations to observations, components and component values (according to SDMX Information Model). Annotations can now be attached to structure, component, component value, dataSet, series and observation. Updated the examples and schema accordingly.

@dosse dosse closed this Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment