Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable Flow table lookup for incoming packets #62

Closed
twood02 opened this issue Dec 4, 2018 · 4 comments
Closed

Enable/Disable Flow table lookup for incoming packets #62

twood02 opened this issue Dec 4, 2018 · 4 comments
Labels
good first issue Simple issues for new ONVM developers to help with! high priority ❗

Comments

@twood02
Copy link
Member

twood02 commented Dec 4, 2018

This issue describes a simple bug/improvement for the OpenNetVM code, and is a great way for YOU to get involved with improving this open source project! If you want to fix it, just create a pull request with the fix as detailed in the Contributing document. If you have questions, post here!


By default, ONVM does a flow table lookup for all newly arrived packets (using our Flow Director API). However, many users don't use the built-in flow table, so this is wasteful since packets just get sent to the default (service ID 1).

Instead, this should be configurable either as a compile time variable or a command line argument to control whether a lookup is performed or not.

The code to change is here:

ret = onvm_flow_dir_get_pkt(pkts[i], &flow_entry);
if (ret >= 0) {
sc = flow_entry->sc;
meta->action = onvm_sc_next_action(sc, pkts[i]);
meta->destination = onvm_sc_next_destination(sc, pkts[i]);
} else {
meta->action = onvm_sc_next_action(default_chain, pkts[i]);
meta->destination = onvm_sc_next_destination(default_chain, pkts[i]);
}

@twood02 twood02 added the good first issue Simple issues for new ONVM developers to help with! label Dec 4, 2018
@harsh503
Copy link

harsh503 commented Dec 8, 2018

For default case, should it perform a flow table lookup or not?

@twood02
Copy link
Member Author

twood02 commented Dec 8, 2018

The default should be the same as now - a flow lookup should happen.

@kevindweb
Copy link
Contributor

This is done, we should close the issue.

@koolzz
Copy link
Member

koolzz commented Jul 7, 2019

Good point, use your powers @kevindweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple issues for new ONVM developers to help with! high priority ❗
Projects
None yet
Development

No branches or pull requests

4 participants