Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM #1

Merged
merged 5 commits into from Mar 5, 2019
Merged

DOM #1

merged 5 commits into from Mar 5, 2019

Conversation

sdoylelambda
Copy link
Owner

@LizBaker

Thanks!

LizBaker
LizBaker reviewed Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@LizBaker LizBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off to a good start! I'd come back to this and make sure you can sort through it (use solution for help too if you need)

js/index.js
navigation.children[2].textContent = 'Services';
navigation.children[3].textContent = 'Services';
navigation.children[4].textContent = 'Services';
navigation.children[5].textContent = 'Services';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to make these all different words 😝 . we also wanted to use the siteContent object instead of hardcoding. textContent = siteContent.nav["nav-item-1"] etc

js/index.js
let btnID = document.getElementById("button");
// btnID.textContent = siteContent.cta['button'];

// // Main Paragraph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a next step here might be to query for all P tags and then change them on by one allmahPtags[0].textContent = siteContent["main-content"]["features-content"] allmahPtags[1].textContent = siteContent["main-content"]["about-content"] etc

@LizBaker LizBaker merged commit e4056f8 into master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaker LizBaker LizBaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sdoylelambda @LizBaker