Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds c implementation of tfidfvectorizer and python implementation of tokenizer #111

Merged
merged 10 commits into from
Nov 12, 2023

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Nov 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (9c6a709) 83.80% compared to head (63b806b) 82.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   83.80%   82.64%   -1.17%     
==========================================
  Files          47       49       +2     
  Lines        6378     6516     +138     
==========================================
+ Hits         5345     5385      +40     
- Misses       1033     1131      +98     
Files Coverage Δ
onnx_extended/reference/c_reference_evaluator.py 90.47% <100.00%> (+0.11%) ⬆️
..._extended/reference/c_ops/c_op_tfidf_vectorizer.py 60.00% <60.00%> (ø)
onnx_extended/reference/other_ops/op_tokenizer.py 14.58% <14.58%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdpython sdpython marked this pull request as ready for review November 12, 2023 00:52
@sdpython sdpython merged commit f47863a into main Nov 12, 2023
22 checks passed
@sdpython sdpython deleted the tfidf branch November 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants