Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i18n support and spanish translation #38

Merged
merged 5 commits into from
Jun 2, 2019

Conversation

ajerez
Copy link
Contributor

@ajerez ajerez commented May 29, 2019

馃檪馃嚜馃嚫

@pnevares
Copy link
Contributor

I love this idea!

A package-lock.json was included in this PR, looks like yarn.lock is the file in use for this project.

@ajerez
Copy link
Contributor Author

ajerez commented May 30, 2019

I love this idea!

A package-lock.json was included in this PR, looks like yarn.lock is the file in use for this project.

Fixed, thanks :)

@sdras
Copy link
Owner

sdras commented Jun 2, 2019

I love this :) A couple of questions:

  • I didn't see an implementation of a language switcher. Am I blind and missing it (totally possible) or has it not been implemented again (I don't mind doing it myself if so)
  • I need to update some of the text in the explanation. Would you prefer I do this now, before this is merged, or would it be better for you after and then you submit another PR? Are you ok with maintaining the Spanish version moving forward?

Thanks!

This was referenced Jun 2, 2019
@ajerez
Copy link
Contributor Author

ajerez commented Jun 2, 2019

I love this :) A couple of questions:

  • I didn't see an implementation of a language switcher. Am I blind and missing it (totally possible) or has it not been implemented again (I don't mind doing it myself if so)
  • I need to update some of the text in the explanation. Would you prefer I do this now, before this is merged, or would it be better for you after and then you submit another PR? Are you ok with maintaining the Spanish version moving forward?

Thanks!

Yes, sorry, the code loads the app with your browser language but there is no language selector.

I've updated the PR with the translation for the new Screenreaders note and the last PRs texts.
Of course I'd be glad to maintaining the spanish version :)

Thanks for all

@trickstival
Copy link
Contributor

That's super cool. Once it's approved I can help with a portuguese translation

@sdras
Copy link
Owner

sdras commented Jun 2, 2019

Great! Let's do this 馃

@sdras sdras merged commit a6fced6 into sdras:master Jun 2, 2019
@ajerez ajerez deleted the i18n-and-spanish branch June 3, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants