Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .DS_Store #3

Closed
sdras opened this issue Sep 10, 2018 · 3 comments
Closed

Remove .DS_Store #3

sdras opened this issue Sep 10, 2018 · 3 comments

Comments

@sdras
Copy link
Owner

sdras commented Sep 10, 2018

Remove unneeded files like .DS_Store. Possibly node_modules as well.
@farskid
Copy link

farskid commented Sep 10, 2018

I think this is related to #8

Is there any case in which we need to cover .gitignore files?

@sdras
Copy link
Owner Author

sdras commented Sep 10, 2018

Yeah, I think we would read what's in .gitignore and then exclude them. I can probably make a small PR that removes .DS_Store and node_modules very quickly. The .gitignore idea might take a bit longer because if it takes some time to run and has to do error handling we might also need a loader. But it would be much more elegant so I think that's what we should do eventually.

@sdras
Copy link
Owner Author

sdras commented Sep 11, 2018

This is now done! See #8 for more info 🎉

@sdras sdras closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdras @farskid