Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipeline setting to trigger on certain branch names #61

Closed
sdresselmann opened this issue Apr 21, 2024 · 0 comments
Closed

update pipeline setting to trigger on certain branch names #61

sdresselmann opened this issue Apr 21, 2024 · 0 comments
Assignees
@sdresselmann
Labels
documentation Improvements or additions to documentation

Comments

@sdresselmann
Copy link
Owner

sdresselmann commented Apr 21, 2024 •
edited

The pipelines for running tests and formatting code should be triggered when branches are pushed to, not just when pull requests are opened. This ensures that errors are detected immediately upon pushing changes, rather than waiting until a pull request is opened.

Trigger on branch names:

  • feature/
  • task/
  • bugfix/
  • hotfix/
@sdresselmann sdresselmann self-assigned this Apr 21, 2024
@sdresselmann sdresselmann added the documentation Improvements or additions to documentation label Apr 21, 2024
@sdresselmann sdresselmann changed the title Update pipeline setting to trigger on branch names update pipeline setting to trigger on certain branch names Apr 21, 2024
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(.env): delete .env from vcs
683c95e
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(.env): delete .env from vcs
3623531
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(.env): replace env calls with dart define
bbbd093 
This should also allow for easier integration inside the GitHub pipeline, by accessing the secrets.
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(pipeline): update flutter version
4d13df6
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(pipeline): add github secret keys to test run
0de4715
sdresselmann added a commit that referenced this issue Apr 25, 2024
@sdresselmann
#61 - task(pipeline): revert adding github secret key
d085a47 
The previous change was only for testing purposes, currently they are not needed for functionality.
sdresselmann added a commit that referenced this issue Apr 27, 2024
@sdresselmann
#61 - task(firestore service): remove raw firebase data type
8b32e1b 
The type is no longer required.
sdresselmann added a commit that referenced this issue Apr 27, 2024
@sdresselmann
#61 - task(firestore service): add converters for firestore data
0ec3e7c 
While this solution comes with quite a bit of boilerplate code, this seems to be the most straight forward way without any auto generation of code from mapper libraries.
sdresselmann added a commit that referenced this issue Apr 27, 2024
@sdresselmann
#61 - task(firestore service): add service interface for firestore API
ac8a8e9 
Sadly the converter solution was a dead end, due to dart not being able to invoke interface methods via generic types.

However, a similar solution is utilizing a middleware service for each requested entity, that fetched the required json data from the firestore and calls the corresponding toJson/fromJson method to map json data to entity model.
sdresselmann added a commit that referenced this issue Apr 28, 2024
@sdresselmann
#61 - task(firestore service): rename firestore service methods
6cd4538 
This way their naming corresponds which the related firestore API call. This improves readability and comprehensibility of the API usage.
sdresselmann added a commit that referenced this issue Apr 28, 2024
@sdresselmann
#61 - task(firestore service): remove commented out code
be628bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdresselmann sdresselmann

Labels
documentation Improvements or additions to documentation
Projects
Herculade project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdresselmann