-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing reference tests 3341/13 and 3341/14 #10
Comments
I had a quick look into this, and I have a question: Where does your chunk size of 100 ms come from? I ask, because if I go down to a chunk size of 10 ms (20 ms also seem to work, anything larger causes the tests to fail again) like so: for chunk in samples.chunks(2 * 48_000 / 100) {
e.add_frames_i32(chunk).expect("Failed to analyze samples");
let loudness = e
.loudness_momentary()
.expect("Failed to get momentary loudness");
if loudness > max_loudness {
max_loudness = loudness;
}
} The tests pass (the |
Just for clarification, I looked at the chunk size because these tests ask for a maximum momentary loudness and while even momentary loudness has a 400ms window, it is still a sliding window and the maximum can occur at any point. (I didn't check the |
Makes sense. I didn't put much thought into the chunk size :) can you update the PR to use 10ms? That seems like a nicer number to understand the calculations around it. Thanks! |
Done 🙂 |
See #9
The text was updated successfully, but these errors were encountered: