Add tutorial 5, similar to the one from gst-docs. #41

thiblahute · 2017-10-11T14:38:58Z

And "Add a Bus.async_signal_func helper function"

sdroege

I think you want to run all this once through rustfmt-nightly :)

sdroege · 2017-10-11T16:37:40Z

tutorials/src/bin/basic-tutorial-5.rs

@@ -0,0 +1,377 @@
+#[cfg(feature = "tutorial5")]


I'd suggest to move all this into a sub-module so that you have to put the feature gate only once or twice :)

sdroege · 2017-10-11T16:38:44Z

tutorials/src/bin/basic-tutorial-5.rs

+fn add_streams_info(
+    playbin: &gst::Element,
+    textbufcell: &SendCell<gtk::TextBuffer>,
+    stype: String,


&str would be nicer

sdroege · 2017-10-11T16:40:27Z

tutorials/src/bin/basic-tutorial-5.rs

+// Extract metadata from all the streams and write it to the text widget in the GUI
+fn analyze_streams(playbin: &gst::Element, textbufcell: &SendCell<gtk::TextBuffer>) {
+    let text = "";
+    {


text is only used once, and only in this block here, not outside

sdroege · 2017-10-11T16:41:19Z

tutorials/src/bin/basic-tutorial-5.rs

+
+        match pipeline.query_duration(gst::Format::Time) {
+            Some(x) => {
+                let seconds = (x as u64) / gst::SECOND;


if let Some(dur) = pipeline.query_...

sdroege · 2017-10-11T16:41:49Z

tutorials/src/bin/basic-tutorial-5.rs

+                    gst::SeekFlags::FLUSH | gst::SeekFlags::KEY_UNIT,
+                    ((value * gst::SECOND) as i64),
+                )
+                .is_err()


if let Err(_) = pipeline.seek_simple(

sdroege · 2017-10-11T16:43:01Z

tutorials/src/bin/basic-tutorial-5.rs

+        let position = pipeline.query_position(gst::Format::Time);
+        if let Some(position) = position {
+            let seconds = (position as u64) / gst::SECOND;
+            signal::signal_handler_block(lslider, from_glib(slider_update_signal_id));


The from_glib should not be needed at all here. If connect_value_changed returns an u64 instead, you found a bug in gtk-rs and can submit a PR there :)

It returns a SignalHandlerId no a u64 as all other signals iiuc.

To be fixed then :)

sdroege · 2017-10-11T16:44:27Z

tutorials/src/bin/basic-tutorial-5.rs

+
+    // Initialize GTK
+    if gtk::init().is_err() {
+        eprintln!("Failed to initialize GTK.");


if let Err(err) = gtk::init() and then also print the error. Same for GStreamer. is_err, is_some and all these are usually not nice

sdroege · 2017-10-11T16:45:17Z

tutorials/src/bin/basic-tutorial-5.rs

+    let playbin = gst::ElementFactory::make("playbin", None).unwrap();
+    if playbin
+        .set_property("uri", &glib::Value::from(uri))
+        .is_err()


unwrap(), this never fails unless you fail to type :)

sdroege · 2017-10-11T16:45:59Z

tutorials/src/bin/basic-tutorial-5.rs

+
+    let bus = playbin.get_bus().unwrap();
+    let pipeline = playbin.clone();
+    bus.add_watch(gst::Bus::async_signal_func);


Isn't that the same as bus.add_signal_watch()?

lol, not sure how I forgot and ended up adding the API :-)

Removed Bus::async_signal_func it should not be so useful, let me know if you want me to open a PR to re add it.

No that's fine :) I didn't add it before because it seemed a bit useless

sdroege · 2017-10-11T17:51:17Z

tutorials/src/bin/basic-tutorial-5.rs

+            .connect_value_changed(move |slider| {
+                let pipeline = &pipeline;
+                let value = slider.get_value() as u64;
+                if let Err(_) = pipeline .seek_simple(


Space before .seek_simple

sdroege · 2017-10-11T17:52:03Z

tutorials/src/bin/basic-tutorial-5.rs

+                    eprintln!("Seeking to {} failed", value);
+                }
+            })
+            .to_glib();


to_glib() also shouldn't be here. The from_glib_* and to_glib_* functions are all meant for the bindings code only, or when you interact with the C functions directly

sdroege · 2017-10-11T17:54:10Z

tutorials/src/bin/basic-tutorial-5.rs

+        let pipeline = playbin.clone();
+        bus.add_signal_watch();
+        playbin.get_bus().unwrap().connect_message(move |_, msg| {
+            //let streams_view = &streams_view;


Commented out, why?

thiblahute · 2017-10-12T09:43:01Z

This now depends on gtk-rs/glib#240

sdroege

Looks good, just need to get the glib change merged first

sdroege · 2017-10-14T10:02:24Z

I'll merge this later, thanks a lot :)

thiblahute force-pushed the tutorial-5 branch from 6657517 to ad81ef1 Compare October 11, 2017 14:39

thiblahute changed the title ~~Add tutorial 5, similare from the one from gst-docs.~~ Add tutorial 5, similar to the one from gst-docs. Oct 11, 2017

thiblahute force-pushed the tutorial-5 branch from ad81ef1 to 8b26400 Compare October 11, 2017 15:59

sdroege requested changes Oct 11, 2017

View reviewed changes

thiblahute force-pushed the tutorial-5 branch 2 times, most recently from 615458c to ec79ffd Compare October 11, 2017 17:42

sdroege requested changes Oct 11, 2017

View reviewed changes

Add the tutorial5 (Gtk video player with informations about streams)

61c6f34

thiblahute force-pushed the tutorial-5 branch from ec79ffd to 61c6f34 Compare October 12, 2017 09:42

sdroege approved these changes Oct 12, 2017

View reviewed changes

sdroege closed this in faae914 Oct 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tutorial 5, similar to the one from gst-docs. #41

Add tutorial 5, similar to the one from gst-docs. #41

thiblahute commented Oct 11, 2017

sdroege left a comment

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

thiblahute Oct 11, 2017

sdroege Oct 11, 2017

sdroege Oct 11, 2017

sdroege Oct 11, 2017

sdroege Oct 11, 2017

thiblahute commented Oct 12, 2017

sdroege left a comment

sdroege commented Oct 14, 2017

Add tutorial 5, similar to the one from gst-docs. #41

Add tutorial 5, similar to the one from gst-docs. #41

Conversation

thiblahute commented Oct 11, 2017

sdroege left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thiblahute commented Oct 12, 2017

sdroege left a comment

Choose a reason for hiding this comment

sdroege commented Oct 14, 2017