Add MPEG-TS library #4
Conversation
…binding for GStreamer MPEG-TS library.
gstreamer-mpegts-sys/Cargo.toml
Outdated
| name = "gstreamer_mpegts_sys" | ||
|
|
||
| [package] | ||
| authors = ["Russel Winder <russel@winder.org.uk>"] |
There was a problem hiding this comment.
Add me there too please, otherwise I can't upload that to crates.io with all the other things :)
gstreamer-mpegts-sys/Cargo.toml
Outdated
| name = "gstreamer-mpets-sys" | ||
| readme = "README.md" | ||
| repository = "https://github.com/sdroege/gstreamer-sys" | ||
| version = "0.0.0" |
There was a problem hiding this comment.
Same version number as the other crates
| @@ -0,0 +1,31 @@ | |||
| # gstreamer-sys [](https://crates.io/crates/gstreamer-sys) [](https://travis-ci.org/sdroege/gstreamer-sys) | |||
There was a problem hiding this comment.
gstreamer-audio-sys/README.md and gstreamer-app-sys/README.md both have the above, so I just followed suit.
gstreamer-mpegts-sys/Cargo.toml
Outdated
| v1_6 = ["v1_4"] | ||
| v1_8 = ["v1_6"] | ||
| v1_10 = ["v1_8"] | ||
| v1_12 = ["v1_10"] |
There was a problem hiding this comment.
All this feature stuff not needed as you have 1.12 as min
|
It's a pity that the way the changes got squash merged makes it appear that the PR has been rejected when in fact they are all accepted. Thanks for accepting them. |
|
I'd like to keep the GIT history clean. No rewriting of history after pushed, but PRs and others get squashed together into their functional changes without having the whole review process part of the GIT history. You can also do that yourself and just force-push updated commits to the PR :) |
|
Your repo, your rules. :-) I guess I just go with actual history as it was, not worrying about keeping a linear single commit trail – though no rewriting after push definitely. (I'm currently tinkering with the related GStreamer-Rs bit of MPEG-TS. I suspect there may be questions, but more fidddling needed first.) |
I believe this is a reasonable version now. Certainly it compiles with just a few warnings about capitalisation of some names.