Make basic UI #1

GuillaumeGomez · 2018-09-30T11:38:59Z

cc @sdroege

GuillaumeGomez · 2018-09-30T11:39:18Z

We should maybe a license as well, no?

sdroege · 2018-09-30T12:07:16Z

We should maybe a license as well, no?

Yes, I'd vote MIT as that's about as liberal as it gets

sdroege · 2018-09-30T12:12:08Z

src/main.rs

+        p.set_website_label(Some("github repository"));
+        p.set_website(Some("https://github.com/sdroege/rustfest-rome18-gtk-gst-workshop"));
+        p.set_comments(Some("A process viewer GUI wrote with gtk-rs"));
+        // p.set_copyright(Some("This is under MIT license"));


sdroege · 2018-09-30T12:12:15Z

src/main.rs

+        p.set_authors(&["Sebastian Dröge", "Guillaume Gomez"]);
+        p.set_website_label(Some("github repository"));
+        p.set_website(Some("https://github.com/sdroege/rustfest-rome18-gtk-gst-workshop"));
+        p.set_comments(Some("A process viewer GUI wrote with gtk-rs"));


Not a process viewer ;)

sdroege · 2018-09-30T12:13:57Z

src/main.rs

+    menu_bar.append_submenu("?", &about_menu);
+
+    // Connect the about menu entry click event.
+    let about = gio::SimpleAction::new("about", None);


Modern GTK apps usually put this (and global preferences, etc) into the global per application menu, not inside the application. And inside the application there's usually a hamburger menu on the right for window-specific settings

Never heard of it and my searches gave nothing. Is it a gtk/gio thing?

I thought that's what the gio::MenuItem stuff is already doing but apparently not. If you run gnome-shell and open e.g. gedit, you'll have various of it's global menu items in the gnome-shell menu. And then various window-specific ones in the hamburger menu at the top-right (save as, find, etc.).

I'll research for the global menu tomorrow :)

That's weird... Waiting more info on this. :D

diff --git a/src/main.rs b/src/main.rs index 00eea79..2992d52 100644 --- a/src/main.rs +++ b/src/main.rs @@ -21,13 +21,10 @@ macro_rules! upgrade_weak { fn build_menu(application: &gtk::Application, window: &gtk::ApplicationWindow) { let menu = gio::Menu::new(); - let menu_bar = gio::Menu::new(); - let about_menu = gio::Menu::new(); - menu.append("Quit", "app.quit"); - about_menu.append("About", "app.about"); - menu_bar.append_submenu("?", &about_menu); + let about_menu = gio::MenuItem::new("About", "app.about"); + menu.append_item(&about_menu); // Connect the about menu entry click event. let about = gio::SimpleAction::new("about", None); @@ -37,13 +34,15 @@ fn build_menu(application: &gtk::Application, window: &gtk::ApplicationWindow) { let p = gtk::AboutDialog::new(); p.set_authors(&["Sebastian Dröge", "Guillaume Gomez"]); p.set_website_label(Some("github repository")); - p.set_website(Some("https://github.com/sdroege/rustfest-rome18-gtk-gst-workshop")); + p.set_website(Some( + "https://github.com/sdroege/rustfest-rome18-gtk-gst-workshop", + )); p.set_comments(Some("A process viewer GUI wrote with gtk-rs")); // p.set_copyright(Some("This is under MIT license")); p.set_transient_for(Some(&window)); + p.set_modal(true); p.set_program_name("Rustfest GTK+GStreamer"); - p.run(); - p.destroy(); + p.show_all(); }); let quit = gio::SimpleAction::new("quit", None); let weak_window = window.downgrade(); @@ -56,7 +55,6 @@ fn build_menu(application: &gtk::Application, window: &gtk::ApplicationWindow) { application.add_action(&quit); application.set_app_menu(&menu); - application.set_menubar(&menu_bar); } fn build_ui(application: &gtk::Application) {

sdroege · 2018-09-30T12:14:59Z

src/main.rs

+        p.set_transient_for(Some(&window));
+        p.set_program_name("Rustfest GTK+GStreamer");
+        p.run();
+        p.destroy();


I'd recommend not doing a recursive main loop here. Just do p.show() and for destroying you can connect to signals on the dialog. See the listbox example

It's the recommended way to do it.

Where does it say so? :)

The problem with this is that you can very easily run into multiple mutable borrows of a RefCell for example by doing this. As while the dialog is running, everything (incl all other signal handlers) are called from inside p.run().

In the examples but I'll update it if you prefer, I don't really mind. :)

See #1 (comment)

In the context of Rust I'd really recommend to not do recursive main loops. RefCell will easily panic on you then if you're not careful, and there's not really any advantage (unlike in C) because we have cheap and ergonomic closures

sdroege · 2018-09-30T12:15:43Z

src/main.rs

+extern crate gtk;
+
+use gio::prelude::*;
+use gio::MenuExt;


Why is MenuExt no in the gio prelude?

This is a pretty good question!

We should fix that :)

Indeed but that won't get in before rustfest I assume.

Not a new release, yes. Unless you do a bugfix release for that (I do bugfix releases for such things and lots of other stuff in gstreamer-rs regularly as it makes users happy and is not much effort, see https://github.com/sdroege/gstreamer-rs/blob/master/gstreamer/CHANGELOG.md)

Let's say I'll think about. :-.

GuillaumeGomez · 2018-10-08T21:03:05Z

Updated, sorry for the delay!

sdroege · 2018-10-09T06:19:43Z

src/main.rs

+        p.set_website(Some(
+            "https://github.com/sdroege/rustfest-rome18-gtk-gst-workshop",
+        ));
+        p.set_comments(Some("A video input reader written with gtk-rs and gstreamer-rs"));


"A webcam viewer written ..." seem better :)

sdroege · 2018-10-09T06:20:12Z

src/main.rs

+        p.set_copyright(Some("This is under MIT license"));
+        p.set_transient_for(Some(&window));
+        p.set_modal(true);
+        p.set_program_name("Rustfest GTK+GStreamer");


RustFest with capital F AFAIU?

sdroege · 2018-10-09T06:20:31Z

src/main.rs

+fn build_ui(application: &gtk::Application) {
+    let window = gtk::ApplicationWindow::new(application);
+
+    window.set_title("Rustfest 2018 GTK+GStreamer");


sdroege · 2018-10-09T06:21:26Z

src/main.rs

+    application.connect_startup(|app| {
+        build_ui(app);
+    });
+    application.connect_activate(|_| {});


Why do we have this empty signal handler?

Because of:

(.:91070): GLib-GIO-WARNING **: 08:58:30.931: Your application does not implement g_application_activate() and has no handlers connected to the 'activate' signal. It should do one of these.

I've removed it anyway.

Then keep it, warnings are not good :) We should probably do something in activate though?

I assume activate should be the one that creates the UI, while startup only cares for the menu registration and stuff? Or maybe activate should only call window.show_all()?

Or maybe we shouldn't use startup at all? It sounds like that signal is mostly for internal reasons to decide if the application is already running or not?

Asked on the GTK IRC channel, the docs are not clear at all

sdroege · 2018-10-09T06:21:46Z

Thanks, just minor stuff missing. Just merge after those are done :)

sdroege reviewed Sep 30, 2018

View reviewed changes

GuillaumeGomez force-pushed the ui branch from ba4933c to 502582b Compare September 30, 2018 20:00

GuillaumeGomez force-pushed the ui branch from 502582b to 513336f Compare October 8, 2018 21:02

GuillaumeGomez mentioned this pull request Oct 8, 2018

No dialogs should use "run" and "destroy" GuillaumeGomez/process-viewer#91

Closed

sdroege reviewed Oct 9, 2018

View reviewed changes

sdroege mentioned this pull request Oct 9, 2018

Don't use Dialog::run() as it creates recursive/reentrant main loops gtk-rs/examples#196

Open

Make basic UI

867a94a

GuillaumeGomez force-pushed the ui branch from 513336f to 867a94a Compare October 9, 2018 07:01

GuillaumeGomez merged commit 172fa34 into master Oct 9, 2018

GuillaumeGomez deleted the ui branch October 9, 2018 07:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make basic UI #1

Make basic UI #1

GuillaumeGomez commented Sep 30, 2018

GuillaumeGomez commented Sep 30, 2018

sdroege commented Sep 30, 2018

sdroege Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018

GuillaumeGomez Sep 30, 2018

sdroege Sep 30, 2018 •

edited

GuillaumeGomez Sep 30, 2018

GuillaumeGomez commented Oct 8, 2018

sdroege Oct 9, 2018

sdroege Oct 9, 2018

sdroege Oct 9, 2018

sdroege Oct 9, 2018

GuillaumeGomez Oct 9, 2018

sdroege Oct 9, 2018

sdroege Oct 9, 2018

sdroege Oct 9, 2018

sdroege commented Oct 9, 2018

Make basic UI #1

Make basic UI #1

Conversation

GuillaumeGomez commented Sep 30, 2018

GuillaumeGomez commented Sep 30, 2018

sdroege commented Sep 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdroege Sep 30, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillaumeGomez commented Oct 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdroege commented Oct 9, 2018

sdroege Sep 30, 2018 •

edited