-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Output dummy puts statements for plain text nodes
We were getting false positives about ternary statements from the `RuboCop` lint for code like the following: - if something Some plain text - else Some other plain text This was because the code being generated ignored plain text nodes, so it would produce: if something else end ...causing the lint to be reported. The solution was to output dummy `puts` statements for plain text nodes. Change-Id: I86f110b32ee3503482c937a6ae673251545aab15 Reviewed-on: http://gerrit.causes.com/45070 Tested-by: jenkins <jenkins@brigade.com> Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
- Loading branch information
Showing
3 changed files
with
17 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters