Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImplicitDiv raises issue incorrectly #33

Closed
hackling opened this issue Sep 30, 2014 · 4 comments
Closed

ImplicitDiv raises issue incorrectly #33

hackling opened this issue Sep 30, 2014 · 4 comments
Labels

Comments

@hackling
Copy link
Contributor

If I have the following haml, I expect haml-lint to give me an ImplicitDiv warning, which it currently does.

  %div.supervisor-page

However if I have the following haml, I would expect it to not raise an ImplicitDiv warning.

  %div{id: leaderboard.code}

Yet it does, and the suggestion that it offers isn't quite right either.

[W] ImplicitDiv: `%div` can be written as `.code}` since `%div` is implicit

It seems to think that my method call anywhere after %div is supposed to be the class that I'm using on the div.

@glittershark
Copy link

👍

@sds sds added the bug label Oct 7, 2014
@sds
Copy link
Owner

sds commented Oct 7, 2014

Fixed by @hackling in #34. Thanks for the report!

@sds sds closed this as completed Oct 7, 2014
@glittershark
Copy link

yay!

@gabrielosorio
Copy link

I'm also getting a false positive with an email view since I had to style it inline:

%div{ style: 'width: 600px; padding: 40px; margin: 0 auto; background-color: #282f36;' }

Getting:

`%div` can be written as `#282f36;'` since `%div` is implicit

Appreciate all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants