Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImplicitDiv issues with dynamic ids after unclassed divs #34

Closed
wants to merge 2 commits into from

Conversation

hackling
Copy link
Contributor

Fixes #33

Credit to @parameme for his help with the regular expression solution

The ImplicitDiv linter has issues when an unclassed div has a preceding dynamic id.

The following examples will not report a lint, as I believe was the original intention of the linter.

%div{id: object.to_s}
%div[object.to_s]

I have confirmed that this change does not break any existing tests

Finished in 0.74166 seconds (files took 0.62902 seconds to load)
194 examples, 0 failures

@sds sds added the bug label Oct 7, 2014
@sds
Copy link
Owner

sds commented Oct 7, 2014

Thanks for the pull request, @hackling, and doubly so for writing tests.

Merged in 936fd8e.

@sds sds closed this Oct 7, 2014
@hackling
Copy link
Contributor Author

hackling commented Oct 8, 2014

@sds No problem. If you remember, can you please let me know when you bump the gem version, so I can update it and turn the ImplicitDiv linter on in our build server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImplicitDiv raises issue incorrectly
2 participants