accessibility rules - check for missing alt attributes #69
Comments
|
Hey @ckundo, Thanks for suggesting ways to improve The concern here is that HAML may not be the right place to do this kind of enforcement. There are some uses of HAML which the intended consumer is not a user-facing website, so such lints would not be useful. I'm curious to see what you are proposing. Ideally, any linters would be backed by a relevant RFC or W3C standard of some sort, and not just be some "best practice." Depending on the scope of these linters we might also end up namespacing them so they can be enabled/disabled wholesale with something like: linters:
Accessibility::*:
enabled: trueInterested in seeing what you have to propose. |
- Introduces a new method to check if an attribute exists in a tag nodes hash attributes - Required for followup commit to check for missing alt attributes [sds#69]
- alternative text is required for non text content - http://www.w3.org/TR/2008/REC-WCAG20-20081211/#text-equiv-all [sds#69]
|
Hey @sds, I submitted a PR, I welcome your review and feedback. Thanks! |
- Introduces a new method to check if an attribute exists in a tag nodes hash attributes - Required for followup commit to check for missing alt attributes [sds#69]
- alternative text is required for non text content - http://www.w3.org/TR/2008/REC-WCAG20-20081211/#text-equiv-all [sds#69]
- Introduces a new method to check if an attribute exists in a tag nodes hash attributes - Required for followup commit to check for missing alt attributes [sds#69]
- alternative text is required for non text content - http://www.w3.org/TR/2008/REC-WCAG20-20081211/#text-equiv-all [sds#69]
- Introduces a new method to check if an attribute exists in a tag nodes hash attributes - Required for followup commit to check for missing alt attributes [sds#69]
- alternative text is required for non text content - http://www.w3.org/TR/2008/REC-WCAG20-20081211/#text-equiv-all [sds#69]
- alternative text is required for non text content - http://www.w3.org/TR/2008/REC-WCAG20-20081211/#text-equiv-all Finishes #69 Change-Id: I1e13fc15524a4a42151972cd55ef1de4826da2ec Reviewed-on: http://gerrit.causes.com/48346 Reviewed-by: Shane da Silva <shane.dasilva@brigade.com> Tested-by: Shane da Silva <shane.dasilva@brigade.com>
|
Implemented by #70. Thanks! |
|
Awesome, thanks @sds! |
Have you considered adding some basic accessibility assertions to your rules (i.e. presence of
altattributes,labelassociation on form elements)?I'd like to work on some PRs for accessibility rules, starting with looking for missing
altattributes. Would you be open to that?The text was updated successfully, but these errors were encountered: