Skip to content

Commit

Permalink
Remove unnecessary nesting from TAP reporter output
Browse files Browse the repository at this point in the history
I'm not really sure why I nested this in the first place. I was recently
in here and decided to simplify.
  • Loading branch information
lencioni committed Mar 2, 2016
1 parent e503063 commit 338fcd4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 16 deletions.
7 changes: 3 additions & 4 deletions lib/scss_lint/reporter/tap_reporter.rb
Expand Up @@ -93,10 +93,9 @@ def format_not_ok(lint, test_number)
---
message: #{lint.description}
severity: #{lint.severity}
data:
file: #{lint.filename}
line: #{lint.location.line}
column: #{lint.location.column}
file: #{lint.filename}
line: #{lint.location.line}
column: #{lint.location.column}
...
EOS
end
Expand Down
21 changes: 9 additions & 12 deletions spec/scss_lint/reporter/tap_reporter_spec.rb
Expand Up @@ -67,28 +67,25 @@
---
message: Description of lint 1
severity: warning
data:
file: not-ok1.scss
line: 123
column: 10
file: not-ok1.scss
line: 123
column: 10
...
not ok 3 - not-ok2.scss:20:2 SCSSLint::Linter::PrivateNamingConvention
---
message: Description of lint 2
severity: error
data:
file: not-ok2.scss
line: 20
column: 2
file: not-ok2.scss
line: 20
column: 2
...
not ok 4 - not-ok2.scss:21:3 SCSSLint::Linter::PrivateNamingConvention
---
message: Description of lint 3
severity: warning
data:
file: not-ok2.scss
line: 21
column: 3
file: not-ok2.scss
line: 21
column: 3
...
ok 5 - ok2.scss
EOS
Expand Down

0 comments on commit 338fcd4

Please sign in to comment.