NestingDepth linter not handling rules with no selectors #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,8 +32,7 @@ def visit_rule(node) | |||
|
|
|||
| def ignore_selectors?(node) | |||
| return unless config['ignore_parent_selectors'] | |||
|
|
|||
| simple_selectors(node.parsed_rules).all? do |selector| | |||
| simple_selectors(node.parsed_rules || null_selector).all? do |selector| | |||
There was a problem hiding this comment.
Unless we intend to use the `null_selector elsewhere, it seems simpler (and less code) to have an early return.
return unless node.parsed_rules
|
Thanks for the fix, @cih! I agree an early |
|
No worries, cheers for the feedback @sds, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Guys,
Noticed #541 so I've taken a look at this, when I wrote the initial implementation I didn't realise that
node.parsed_rulescould potentially returnnil. If my understanding is correct aRuleNodecan in some cases returnnilwhen it contains no CSS selectors so I've gone for a somewhat quick and dirty null object, maybe an implicitreturnstatement would do the job?Hope this helps!