Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to publish #21

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Add action to publish #21

merged 6 commits into from
Jan 19, 2023

Conversation

sabinem
Copy link
Member

@sabinem sabinem commented Jan 16, 2023

This PR adds 2 new github workflows:

  • one workflow to publish the package on Pypi: it is triggered by github releases
  • one workflow that is manually triggered to publish on test-Pypi.

Besides these changes:

  • the version is now derived automatically in the __init__.py file, so that it only needs to be set in the pyproject.toml file
  • the readme got a section on how to do a release.

@sabinem sabinem force-pushed the add-action-to-publish branch 2 times, most recently from db712a7 to d868c77 Compare January 16, 2023 13:29
@sabinem sabinem requested a review from a team January 16, 2023 13:30
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Just two tiny comments / questions

README.md Outdated Show resolved Hide resolved
.github/workflows/poetry-publish.yml Outdated Show resolved Hide resolved
@sabinem sabinem force-pushed the add-action-to-publish branch 4 times, most recently from 1385234 to 0a226bd Compare January 17, 2023 16:10
@sabinem sabinem force-pushed the add-action-to-publish branch 5 times, most recently from fdd39d8 to c5b30ea Compare January 19, 2023 06:26
@sabinem sabinem mentioned this pull request Jan 19, 2023
2 tasks
@sabinem sabinem merged commit a6643b8 into main Jan 19, 2023
@cmdoret cmdoret deleted the add-action-to-publish branch January 20, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants