Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gimie Dockerfile #31

Merged
merged 25 commits into from
Feb 9, 2023
Merged

Add gimie Dockerfile #31

merged 25 commits into from
Feb 9, 2023

Conversation

martinfontanet
Copy link
Member

This PR adds a Dockerfile for gimie and a GitHub workflow to push new releases to the container registry.

Here is an execution example:

$ make docker-build
$ sudo docker run gimie --version
gimie 0.2.0

You can execute the command from the container using any of the two following syntaxes:

  • docker run [GIMIE_IMAGE] [ARGUMENTS]
  • docker run [GIMIE_IMAGE] gimie [ARGUMENTS]

I have not tested the CI/CD part yet. I only wrote it following the instructions from the GitHub documentation to publish docker images.

@martinfontanet martinfontanet added the enhancement New feature or request label Feb 6, 2023
@martinfontanet martinfontanet self-assigned this Feb 6, 2023
@martinfontanet martinfontanet linked an issue Feb 6, 2023 that may be closed by this pull request
3 tasks
.github/workflows/docker-publish.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
.github/workflows/docker-publish.yml Show resolved Hide resolved
@cmdoret cmdoret self-requested a review February 9, 2023 14:12
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
One small comment:
Should we name our (GitHub) releases, e.g. "0.2.0" instead of "v0.2.0"? Asking because the image tags don't have the "v". But apparently v0.2.0 is not semver-compatible, so it might be better to just not drop the v.

@martinfontanet
Copy link
Member Author

Looks good to me! One small comment: Should we name our (GitHub) releases, e.g. "0.2.0" instead of "v0.2.0"? Asking because the image tags don't have the "v". But apparently v0.2.0 is not semver-compatible, so it might be better to just not drop the v.

I agree. I think we should drop the "v".

@martinfontanet martinfontanet merged commit 4279cce into main Feb 9, 2023
@cmdoret cmdoret mentioned this pull request Feb 9, 2023
@cmdoret cmdoret deleted the gimie-dockerfile branch March 27, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gimie] Docker container for gimie executable
2 participants