-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gimie Dockerfile #31
Conversation
… gimie-dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One small comment:
Should we name our (GitHub) releases, e.g. "0.2.0" instead of "v0.2.0"? Asking because the image tags don't have the "v". But apparently v0.2.0 is not semver-compatible, so it might be better to just not drop the v.
I agree. I think we should drop the "v". |
This PR adds a Dockerfile for gimie and a GitHub workflow to push new releases to the container registry.
Here is an execution example:
You can execute the command from the container using any of the two following syntaxes:
docker run [GIMIE_IMAGE] [ARGUMENTS]
docker run [GIMIE_IMAGE] gimie [ARGUMENTS]
I have not tested the CI/CD part yet. I only wrote it following the instructions from the GitHub documentation to publish docker images.