Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goto-field macro #6

Merged
merged 19 commits into from
Jun 1, 2022
Merged

Update goto-field macro #6

merged 19 commits into from
Jun 1, 2022

Conversation

albireox
Copy link
Member

Implements an updated goto-field macro in which the initial slew moves the rotator to a fixed mount position. After the FVC loop, which is now independent of the BOSS arcs, a new reslew stage slews the telescope to the field coordinates (including object PA). BOSS calibrations are taken afterwards.

This PR also changes the /RotWrap value in the reslew track command from middle to nearest to try to address COS-64.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #6 (d33e340) into main (6f64a93) will decrease coverage by 2.4%.
The diff coverage is 9.1%.

@@           Coverage Diff           @@
##            main      #6     +/-   ##
=======================================
- Coverage   41.2%   38.8%   -2.3%     
=======================================
  Files         18      18             
  Lines       1295    1351     +56     
  Branches     291     306     +15     
=======================================
- Hits         533     524      -9     
- Misses       698     769     +71     
+ Partials      64      58      -6     
Impacted Files Coverage Δ
src/hal/helpers/boss.py 35.9% <0.0%> (ø)
src/hal/helpers/tcc.py 15.8% <0.0%> (-7.0%) ⬇️
src/hal/macros/goto_field.py 21.5% <8.2%> (-8.2%) ⬇️
src/hal/actor/goto_field.py 65.3% <80.0%> (+7.4%) ⬆️
src/hal/helpers/lamps.py 21.6% <0.0%> (-2.1%) ⬇️
src/hal/macros/macro.py 60.2% <0.0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8a1ed...d33e340. Read the comment docs.

@albireox albireox merged commit 2d7ca72 into main Jun 1, 2022
@albireox albireox deleted the goto-field-fixed-rotator branch June 1, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant