Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement replacement of targets with ToOs #203

Merged
merged 25 commits into from May 24, 2024
Merged

Implement replacement of targets with ToOs #203

merged 25 commits into from May 24, 2024

Conversation

albireox
Copy link
Member

@albireox albireox commented May 6, 2024

Implementation of targets of opportunity. When a Design is created (and unless use_targets_of_opportunity=False) design targets can be replaced with ToOs from a dump file (defaults to $TOO_DATA_DIR/current). The replacement options are managed via configuration.targets_of_opportunity which accepts the following options

configuration:
  targets_of_opportunity:
    replace: true
    path: $TOO_DATA_DIR/current
    exclude_design_modes: ['^.+?_eng$', '^.+?_rm_?.*$']
    max_replacements: 2
    categories: ['science']
    minimum_priority: [6000, 3000, 0]

Enabled only at APO for now.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 89.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 53.5%. Comparing base (0143867) to head (e1ffffa).

Files Patch % Lines
src/jaeger/target/too.py 91.8% 2 Missing and 6 partials ⚠️
src/jaeger/target/coordinates.py 66.7% 3 Missing and 3 partials ⚠️
src/jaeger/target/design.py 87.1% 3 Missing and 1 partial ⚠️
src/jaeger/target/assignment.py 85.8% 1 Missing and 1 partial ⚠️
src/jaeger/utils/utils.py 86.7% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #203     +/-   ##
=======================================
+ Coverage   52.4%   53.5%   +1.1%     
=======================================
  Files         42      43      +1     
  Lines       6499    6656    +157     
  Branches    1557    1578     +21     
=======================================
+ Hits        3403    3558    +155     
+ Misses      2727    2719      -8     
- Partials     369     379     +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit a9801d2 into main May 24, 2024
8 checks passed
@albireox albireox deleted the albireox/too branch May 24, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant