Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] sample.nsa_logmstar broken #1

Closed
albireox opened this issue Nov 2, 2016 · 2 comments
Closed

[CLOSED] sample.nsa_logmstar broken #1

albireox opened this issue Nov 2, 2016 · 2 comments
Labels
bug a general bug or other breaking feature
Milestone

Comments

@albireox
Copy link
Member

albireox commented Nov 2, 2016

Issue by bretthandrews
Thursday Jun 30, 2016 at 16:13 GMT
Originally opened as https://github.com/marvin-manga/marvin/issues/1


The keyword sample.nsa_logmstar is available to query on, but doesn't work.

@albireox
Copy link
Member Author

albireox commented Nov 2, 2016

Comment by havok2063
Thursday Jul 07, 2016 at 01:19 GMT


The sample table is deprecated. At some point we should remove it to avoid confusion and conflict. The NSA parameters are all in sampledb.NSA now. I've modified the SPM SampleModelClasses to include petro_logmass_el and sersic_logmass attributes. These are now usable and filterable by sqlalchemy. If you update the marvin branch of SPM you'll get the changes. These should also be pulled back into the git repo for sampledb.

However, until we can sort out our hybrid property problem, they will continue to be unusable by Marvin Query.

@albireox albireox added this to the Marvin Beta milestone Nov 2, 2016
@albireox albireox added the bug a general bug or other breaking feature label Nov 2, 2016
@albireox
Copy link
Member Author

albireox commented Nov 2, 2016

Comment by havok2063
Thursday Jul 07, 2016 at 13:34 GMT


Closing this since this particular issue has been fixed and the problem essentially shifted to #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a general bug or other breaking feature
Projects
None yet
Development

No branches or pull requests

1 participant