Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Spectrum to Rest Frame in Marvin-web Display #112

Closed
bretthandrews opened this issue Nov 30, 2016 · 12 comments
Closed

Shift Spectrum to Rest Frame in Marvin-web Display #112

bretthandrews opened this issue Nov 30, 2016 · 12 comments
Assignees
Labels
enhancement indicates a new feature or functionality to be added marvin-web an issue related to the Marvin web interface priority-science

Comments

@bretthandrews
Copy link
Contributor

As FuHeng (Eric) Liang suggested, the spectral plot in Marvin-web would be more useful if it was in rest frame.

@bretthandrews bretthandrews added enhancement indicates a new feature or functionality to be added marvin-web an issue related to the Marvin web interface labels Nov 30, 2016
@bretthandrews bretthandrews added this to the Post-Beta milestone Nov 30, 2016
@kbwestfall
Copy link
Member

Maybe a stupid suggestion, but could we have the rest wavelength be labeled on the top axis so that people could see both the observed and rest wavelength? Would we de-redshift based on the NSA redshift, the stellar velocity, or the gas velocity? To keep it simple, I imagine we want to use the bulk redshift from the NSA.

@bretthandrews
Copy link
Contributor Author

Dual wavelength axes is a good suggestion. We'll have to look into Dygraphs to see if it has that functionality (it's not that feature-heavy, so I wouldn't be surprised if it cannot).

As for the redshift to use...I think that the gas or stellar velocity would be more helpful in high S/N regimes but could lead to catastrophic errors in low S/N spaxels.

@havok2063
Copy link
Collaborator

Yeah I agree, dual axes is a better suggestion than replacement or making it toggleable. I had a quick look and it seems Dygraphs does not allow for multiple x axes. y axes yes. The closest out-of-the-box thing looks like plotting it as an independent series.

@kbwestfall
Copy link
Member

If it's easier to toggle, that might be the best solution.

@havok2063
Copy link
Collaborator

havok2063 commented Nov 30, 2016

it wouldn't be trivial to implement, but maybe this means we need to start looking for a new Javascript library that has a bit more functionality, or at the very least, is better documented.

@havok2063
Copy link
Collaborator

Just to expand a bit on the work needed to make it toggleable. We would need to write javascript and html to

  1. Store the wavelength array on the client side
  2. Add a toggle button / checkbox to the interface
  3. Store or compute the rest wavelength on the client side
  4. Re-render the Dygraphs plot fresh from upon button click.

Most of the work is in steps 2 and 4.

@kbwestfall
Copy link
Member

Yeah, doesn't sound trivial. I personally would put this at low priority. It's basically a "polishing" issue, I think.

@havok2063
Copy link
Collaborator

I would agree. I would put this in the category of user freedoms or preferences, similar to maps range rescaling.

@kbwestfall
Copy link
Member

The rescaling of the maps is arguably more important. I think many more people will play with the maps than will actually look at individual spectra.

@havok2063
Copy link
Collaborator

I agree but I think, right now, adding user flexibility on the web interface is a low priority in general, given everything else. I do think moving the DAP custom color scale and custom ranges for defined map-types from the client side into the Marvin data-model, and pushing those custom values to the web, is a priority however.

@albireox
Copy link
Member

Just a comment that this was discussed again today in the DevCon and we agreed to look into it. I'm moving it to backlog.

@havok2063
Copy link
Collaborator

This has been implemented and merged in 2.3.5 for MPL-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement indicates a new feature or functionality to be added marvin-web an issue related to the Marvin web interface priority-science
Projects
None yet
Development

No branches or pull requests

5 participants