Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASKNAME not in MPL-4 header #482

Closed
havok2063 opened this issue Jul 24, 2018 · 2 comments
Closed

MASKNAME not in MPL-4 header #482

havok2063 opened this issue Jul 24, 2018 · 2 comments
Assignees
Labels
bug a general bug or other breaking feature
Milestone

Comments

@havok2063
Copy link
Collaborator

havok2063 commented Jul 24, 2018

Describe the bug
Initializing a Map fails in MPL-4 because MASKNAME is not in the header of MPL-4 data. So all the new maskbit and flag reorganization will fail for MPL-4 data.

To Reproduce

config.setRelease('MPL-4')
from marvin.tools.maps import Maps
maps = Maps('8485-1901')
ha = maps.emline_gflux_ha_6564

Expected behavior
It should initialize correctly.

Additional context
The correct maskbit names for all releases are in the datamodel, so we should consider changing the calls to header['MASKNAME'] to use the datamodel instead. Or alternatively, for MPL-4 headers, add the MASKNAME key when the header gets defined from the MPL-4 datamodel.

@havok2063 havok2063 added the bug a general bug or other breaking feature label Jul 24, 2018
@havok2063 havok2063 added this to the DR15 Freezing milestone Jul 24, 2018
@albireox
Copy link
Member

Let's combine it with #479 and add both qual_flag and pixmask_flag to the datamodel.

@havok2063
Copy link
Collaborator Author

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a general bug or other breaking feature
Projects
None yet
Development

No branches or pull requests

2 participants