Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning that claims mismatch between DR15 and MPL-7 #495

Closed
albireox opened this issue Jul 27, 2018 · 2 comments
Closed

Fix warning that claims mismatch between DR15 and MPL-7 #495

albireox opened this issue Jul 27, 2018 · 2 comments
Assignees
Labels
bug a general bug or other breaking feature priority-medium
Milestone

Comments

@albireox
Copy link
Member

Describe the bug
This warning shows up when trying to open a DR15 file

In [8]: cube = Cube('8485-1901')
fullpath /Users/Brian/Work/sdss/sas/dr15/manga/spectro/redux/v2_4_3/8485/stack/manga-8485-1901-LOGCUBE.fits.gz
/Users/Brian/Work/github_projects/Marvin/python/marvin/tools/cube.py:186: MarvinUserWarning: mismatch between file release=MPL-7 and object release=DR15. Setting object release to MPL-7
  MarvinUserWarning)

To Reproduce
Steps to reproduce the behavior:

  1. Set release to DR15
  2. Switch off any DB
  3. Open a Cube that exists in your local SAS using its plateifu.
  4. Enjoy a warning

Expected behavior
No warnings

Additional context
We can use the aliases in the datamodel to identify releases that are the same.

@albireox albireox added the bug a general bug or other breaking feature label Jul 27, 2018
@albireox albireox added this to the DR15 Freezing milestone Jul 27, 2018
@albireox albireox self-assigned this Nov 13, 2018
@havok2063
Copy link
Collaborator

These will be explicitly different files but the same entry in the database. They both share v2_4_3 as the version.

@albireox
Copy link
Member Author

Yes, I fixed this by comparing the version string instead of the release. This only matter when opening from file because then you can open a file from a release when setting the release to a different one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a general bug or other breaking feature priority-medium
Projects
None yet
Development

No branches or pull requests

2 participants