Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added --https option in sdss_install_bootstrap #49

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Added --https option in sdss_install_bootstrap #49

merged 1 commit into from
Dec 9, 2019

Conversation

nbmurphy
Copy link
Contributor

@nbmurphy nbmurphy commented Dec 9, 2019

I added --https option in sdss_install_bootstrap. This was a missing piece to pull request #47.

@nbmurphy nbmurphy self-assigned this Dec 9, 2019
@coveralls
Copy link

coveralls commented Dec 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 177

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 1.535%
Totals Coverage Status
Change from base Build 176: 0.0%
Covered Lines: 27
Relevant Lines: 1312
💛 - Coveralls

@nbmurphy
Copy link
Contributor Author

nbmurphy commented Dec 9, 2019

I just tested this on my machine. Since it's such a small change, I'm going to go ahead and merge to master, delete tag 1.0.6 and re-tag.

joelbrownstein
joelbrownstein approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@joelbrownstein joelbrownstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nbmurphy nbmurphy merged commit 9863960 into master Dec 9, 2019
@joelbrownstein
Copy link
Contributor

ok, but make new tag 1.0.7 (and don't delete 1.0.6, please)

@joelbrownstein joelbrownstein deleted the https branch December 9, 2019 21:43
@nbmurphy
Copy link
Contributor Author

nbmurphy commented Dec 9, 2019

I apologize @joelbrownstein, I didn’t see your message before I deleted and re-tagged sdss_install 1.0.6. I Just successfully ran sdss_install_bootstrap using the tag 1.0.6. Everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelbrownstein joelbrownstein joelbrownstein approved these changes

Assignees

@nbmurphy nbmurphy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nbmurphy @coveralls @joelbrownstein