Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a database registry #43

Merged
merged 3 commits into from
Oct 28, 2020
Merged

adds a database registry #43

merged 3 commits into from
Oct 28, 2020

Conversation

havok2063
Copy link
Collaborator

This PR adds a new database registry in a utils.registry module. Two new functions are available, list_databases, and display_table. list_databases returns a dictionary of all databases available organized by ORM (peewee or sqlalchemy). Can optionally return a list of schema for each database. display_table turns the database registry into an Astropy Table. This should let us programmatically look up what databases / schema are available.

@havok2063 havok2063 added the enhancement New feature or request label Oct 21, 2020
@coveralls
Copy link

coveralls commented Oct 21, 2020

Pull Request Test Coverage Report for Build 325

  • 0 of 65 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
python/sdssdb/utils/registry.py 0 65 0.0%
Totals Coverage Status
Change from base Build 322: 0.0%
Covered Lines: 0
Relevant Lines: 5239

💛 - Coveralls

Copy link
Member

@albireox albireox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And with typings!

@havok2063 havok2063 merged commit b5c42b1 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants