Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FMPy support #52

Closed
krzysztofarendt opened this issue Dec 18, 2017 · 9 comments · Fixed by #62
Closed

Add FMPy support #52

krzysztofarendt opened this issue Dec 18, 2017 · 9 comments · Fixed by #62
Assignees

Comments

@krzysztofarendt
Copy link
Member

Add FMPy support: https://github.com/CATIA-Systems/FMPy/tree/master/fmpy

@krzysztofarendt
Copy link
Member Author

krzysztofarendt commented Mar 2, 2018

This is not needed, since PyFMI already supports Python 3 and can be installed via conda.
I take it back :-)

@traversaro
Copy link

First of all, thanks for the great library!

Just to add a note about this: one advantage of fmpy over PyFMI is that it can be easily installed with stock pip without the need to use Anaconda. simplifying deployment of the standard system python.

@krzysztofarendt
Copy link
Member Author

Thanks @traversaro, that's a fair point. I reopened the issue, but don't have time to work on it now. It would be probably nice to have a support for both.

Maybe someone would like to look into it?

I think the only class that needs to be adapted is this one:
https://github.com/sdu-cfei/modest-py/blob/master/modestpy/fmi/model.py

@traversaro
Copy link

Thanks @krzysztofarendt . I personally do not have time to look into this right now, but I think having an open issue on this is a starting point, thanks!

@IvannikovG
Copy link

Hi!
If someone knows how to replace pyFMI for fmPY in modestpy please update!

@krzysztofarendt
Copy link
Member Author

krzysztofarendt commented May 16, 2020

We will work on this in this branch: https://github.com/sdu-cfei/modest-py/tree/issue_52_add_fmpy
@filokot

@krzysztofarendt
Copy link
Member Author

krzysztofarendt commented May 16, 2020

The file that needs to be modified is: https://github.com/sdu-cfei/modest-py/blob/master/modestpy/fmi/model.py

@krzysztofarendt
Copy link
Member Author

krzysztofarendt commented Aug 22, 2020

First version of FMPy-based model added: https://github.com/sdu-cfei/modest-py/blob/issue_52_add_fmpy/modestpy/fmi/model.py

TODO:

  • Some tests failing
  • Use fmi.model.Model everywhere, delete estim.model.Model

@krzysztofarendt
Copy link
Member Author

This task will be completed as part of: #62

@krzysztofarendt krzysztofarendt linked a pull request Aug 23, 2020 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants