Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding option to sample from true data frequency instead of logged frequency #16

Closed
kevinykuo opened this issue Jan 8, 2020 · 0 comments · Fixed by #20
Closed

Consider adding option to sample from true data frequency instead of logged frequency #16

kevinykuo opened this issue Jan 8, 2020 · 0 comments · Fixed by #20
Assignees
@kevinykuo
Labels
internal The issue doesn't change the API or functionality
Milestone
0.2.1

Comments

@kevinykuo
Copy link
Contributor

In some applications, using the log-frequency in conditional sampling gives unrealistic samples. Would it be OK if we exposed a parameter to turn this off (defaulting to the current behavior/outlined in the paper, of course):

CTGAN/ctgan/conditional.py

Line 53 in 152da67

tmp = np.log(tmp + 1)

@leix28 @csala
This was referenced Jan 8, 2020
Closed
Merged
@csala csala added this to the 0.2.1 milestone Jan 27, 2020
@csala csala added the internal The issue doesn't change the API or functionality label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinykuo kevinykuo

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Expose log_frequency parameter for conditional sampling kevinykuo/CTGAN
2 participants
@kevinykuo @csala