Expose log_frequency parameter for conditional sampling
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 80.59% 80.63% +0.03%
==========================================
Files 9 9
Lines 500 501 +1
==========================================
+ Hits 403 404 +1
Misses 97 97
Continue to review full report at Codecov.
|
csala
approved these changes
Jan 13, 2020
|
@leix28 could you please take a look? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a parameter,
log_frequency, to thefit()method ofCTGANSynthesizerto allow users to specify whether they want to use log frequency of categorical levels for sampling. The parameter defaults toTruewhich is the current behavior so existing code is not affected. A new unit tests is included to ensure expected behavior when this flag is on/off.Closes #16.