Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TruncNorm to TruncGaussian and make it non standard #102

Closed
JDTheRipperPC opened this issue Aug 27, 2019 · 0 comments · Fixed by #115
Closed

Rename TruncNorm to TruncGaussian and make it non standard #102

JDTheRipperPC opened this issue Aug 27, 2019 · 0 comments · Fixed by #115
Assignees
@JDTheRipperPC
Labels
internal The issue doesn't change the API or functionality
Milestone
0.2.4

Comments

@JDTheRipperPC
Copy link
Collaborator

JDTheRipperPC commented Aug 27, 2019 •
edited by csala
Loading

  • Rename truncnorm.TruncNorm to truncated_gaussian.TruncatedGaussian, following the gaussian naming convention.
  • Compute and use the mean and the standard deviation from the given data
  • Make min and max class parameters. If None, learn them from the data.
  • Add epsilon argument, with default value 0.
@JDTheRipperPC JDTheRipperPC added the internal The issue doesn't change the API or functionality label Aug 27, 2019
@JDTheRipperPC JDTheRipperPC added this to the 0.2.4 milestone Aug 27, 2019
@csala csala changed the title Add new TruncGaussian distribution Rename TruncNorm to TruncGaussian and add mean and std Dec 11, 2019
@csala csala changed the title Rename TruncNorm to TruncGaussian and add mean and std Rename TruncNorm to TruncGaussian and make it non standard Dec 11, 2019
@JDTheRipperPC JDTheRipperPC mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDTheRipperPC JDTheRipperPC

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.2.4
Development

Successfully merging a pull request may close this issue.

renamed univariate truncnorm and make it non standard sdv-dev/Copulas
1 participant
@JDTheRipperPC