Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sampling in select_univariate. #183

Closed
k15z opened this issue Jul 30, 2020 · 0 comments · Fixed by #205
Closed

Use sampling in select_univariate. #183

k15z opened this issue Jul 30, 2020 · 0 comments · Fixed by #205
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@k15z
Copy link
Member

k15z commented Jul 30, 2020

Currently, when applying GaussianCopula to large datasets, the univariate selection procedure takes up a lot of the computation time. We should sample from the dataset when trying to find the best fit univariate; if necessary, we could do some math and figure out the appropriate number of rows for X confidence level with Y hypothesis, but I think ~100 rows should be more than enough.

@csala csala self-assigned this Jan 22, 2021
@csala csala added the feature request Request for a new feature label Jan 22, 2021
@csala csala added this to the 0.3.4 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants