Remove bumpversion and use bump-my-version #380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 27 27
Lines 1791 1791
=======================================
Hits 1556 1556
Misses 235 235 ☔ View full report in Codecov by Sentry. |
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ['copulas', 'copulas.*'] | ||
| namespaces = false | ||
|
|
||
| [tool.bumpversion] | ||
| current_version = "0.10.1.dev0" |
There was a problem hiding this comment.
So this means our version will live in the following places:
- copulas/init.py
- pyproject.toml
Will bump-my-version handle updating it in both places? Based on the code below, it seems like the answer is Yes but just double checking.
There was a problem hiding this comment.
Yeah exactly, I confirmed that both get updated when running bump-my-version bump
There was a problem hiding this comment.
Not really in the context of this PR, but should we get rid of the MANIFEST like we did here
There was a problem hiding this comment.
Looks good!
I found this morning that this in the Makefile should be updated to use pyproject.toml instead of setup.cfg.
Line 225 in 0c42168
CU-86azg17hg
Resolve #377