Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix remote bucket with 's3' #183

Closed
katxiao opened this issue Jan 19, 2023 · 0 comments · Fixed by #185
Closed

Prefix remote bucket with 's3' #183

katxiao opened this issue Jan 19, 2023 · 0 comments · Fixed by #185
Assignees
Milestone

Comments

@katxiao
Copy link
Contributor

katxiao commented Jan 19, 2023

Problem Description

If the user supplies an S3 bucket, we should have them prefix the URL with "s3://"

Eg. "s3://sdv-demo-datasets"

Expected behavior

The following command should run the datasets in the sdv-demo-datasets s3 bucket.

benchmark_single_table(
    ...
    additional_datasets_folder='s3://sdv-demo-datasets',
)
@katxiao katxiao self-assigned this Jan 19, 2023
@katxiao katxiao changed the title Prefix remote bucket with s3 Prefix remote bucket with 's3' Jan 19, 2023
@npatki npatki added this to the 0.6.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants