Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 prefix and fix get size #185

Merged
merged 5 commits into from Jan 23, 2023
Merged

Add s3 prefix and fix get size #185

merged 5 commits into from Jan 23, 2023

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Jan 19, 2023

Resolves #184
Resolves #183
Resolves #182

@katxiao katxiao requested a review from a team as a code owner January 19, 2023 17:47
@katxiao katxiao requested review from pvk-developer and removed request for a team January 19, 2023 17:47
sdgym/utils.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
sdgym/datasets.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing! :shipit:

@katxiao katxiao merged commit 6fd1192 into master Jan 23, 2023
@katxiao katxiao deleted the issue-184-fix-get-size branch January 23, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants