Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept metadata.json as valid metadata file. #194

Closed
katxiao opened this issue Jan 23, 2023 · 0 comments · Fixed by #198
Closed

Accept metadata.json as valid metadata file. #194

katxiao opened this issue Jan 23, 2023 · 0 comments · Fixed by #198
Assignees
@katxiao
Milestone
0.6.0

Comments

@katxiao
Copy link
Contributor

katxiao commented Jan 23, 2023

Problem Description

Currently, we expect the metadata file in datasets to be named metadata_v0.json. This can be confusing since it implies that metadata is versioned. We should accept metadata.json as a valid metadata file.
@katxiao katxiao self-assigned this Jan 23, 2023
@katxiao katxiao mentioned this issue Jan 24, 2023
Merged
@katxiao katxiao added this to the 0.6.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katxiao katxiao

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Update benchmarking and datasets API sdv-dev/SDGym
1 participant
@katxiao