synthesizers=None for benchmark_single_table runs default synthesizers
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
requested review from
amontanez24,
frances-h and
pvk-developer
and removed request for
a team and
amontanez24
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
===========================================
+ Coverage 43.74% 56.56% +12.82%
===========================================
Files 19 19
Lines 1159 1172 +13
===========================================
+ Hits 507 663 +156
+ Misses 652 509 -143
☔ View full report in Codecov by Sentry. |
frances-h
approved these changes
May 30, 2023
frances-h
requested changes
May 30, 2023
sdgym/benchmark.py
Outdated
| @@ -80,6 +80,7 @@ def _generate_job_args_list(limit_dataset_size, sdv_datasets, additional_dataset | |||
| run_id = os.getenv('RUN_ID') or str(uuid.uuid4())[:10] | |||
|
|
|||
| # Get list of synthesizer objects | |||
| synthesizers = DEFAULT_SYNTHESIZERS if synthesizers is None else synthesizers | |||
There was a problem hiding this comment.
Based on the issue, I think we actually want to treat None as not running any synthesizers instead of using the defaults.
amontanez24
approved these changes
Jun 1, 2023
sdgym/benchmark.py
Outdated
| @@ -418,6 +420,29 @@ def _run_jobs(multi_processing_config, job_args_list, show_progress): | |||
| return scores | |||
|
|
|||
|
|
|||
| def _empty_dataframe(compute_quality_score, sdmetrics): | |||
There was a problem hiding this comment.
nitpick: would prefer _get_empty_dataframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #233.