Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The coverage visualization shows empty bar graph for nan values #432

Closed
amontanez24 opened this issue Aug 25, 2023 · 0 comments · Fixed by #424
Closed

The coverage visualization shows empty bar graph for nan values #432

amontanez24 opened this issue Aug 25, 2023 · 0 comments · Fixed by #424
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amontanez24
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDMetrics version: diagnostic-report-properties branch
  • Python version: Any
  • Operating System: Any

Error Description

When examining the coverage property of the DiagnosticReport, if the score is NaN for a column, the bar graph is still made in the visualization and shows as 0. This is confusing since it didn't actually get scored and the column should just not show instead.

Steps to reproduce

from sdmetrics.reports.single_table import DiagnosticReport
from sdv.datasets.demo import download_demo
from sdv.single_table import GaussianCopulaSynthesizer

data, metadata = download_demo('single_table', 'fake_hotel_guests')
synth = GaussianCopulaSynthesizer(metadata)
synth.fit(data)
synthetic_data = synth.sample(len(data))

report = DiagnosticReport()
report.generate(data, synthetic_data, metadata.to_dict(), verbose=True)

report.get_visualization(property_name='Coverage')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants