Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties for diagnostic report #424

Merged
merged 15 commits into from Sep 13, 2023
Merged

Conversation

R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Aug 23, 2023

Resolve #394,
Resolve #395,
Resolve #398,
Resolve #400,
Resolve #409,
Resolve #411,
Resolve #418,
resolve #425,
Resolve #427,
Resolve #429,
Resolve #430,
Resolve #431,
Resolve #432,
Resolve #433

R-Palazzo and others added 7 commits August 23, 2023 08:22
* definition

* unit tests

* integration test

* move integration test

* typo

* typo 2

* docstring
* def 1

* def 2 + test

* docstring

* add test error

* docstring
* definition

* unit test

* integration test

* docstring

* modify integration test

* typo

* quotes

* address comments

* fix lint

* add test error

* sample size

* blank line

* blank line
* coverage

* boundary

* synthesis

* nanmean

* moving integration tests

* rebase
* first changes

* before refactoring quality_report

* refactor quality_report

* print result diagnostic report

* base init

* integration test

* fix test

* docstring

* docstring + get_results without verbose

* check_report_generated

* docstring

* validate_categorical_values

* remove out parameter

* _validate_categorical_values
* define print method + _get_num_iterations

* redefine base multi table property + lint

* def base multi table report

* tests base multi table (stable)

* tests base multi table report

* multi table diagnostic report def + tests

* quality report def + int test + fix cardinality

* unit tests

* move base_report form single_table to report + uti

* remove notebook

* fix minimum version

* fix lint

* address comment 1

* change error message

* details_property to details

* modify get_num_iteration + address comment 2

* change _num_iteration_case names

* remove _only_multi_table attribute

* change error message cardinality

* ind
@R-Palazzo R-Palazzo requested a review from a team as a code owner August 23, 2023 12:11
@R-Palazzo R-Palazzo removed the request for review from a team August 23, 2023 12:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 97.33% and project coverage change: -0.99% ⚠️

Comparison is base (a4e05fd) 77.31% compared to head (d5bada1) 76.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   77.31%   76.33%   -0.99%     
==========================================
  Files          83       91       +8     
  Lines        3394     3304      -90     
==========================================
- Hits         2624     2522     -102     
- Misses        770      782      +12     
Files Changed Coverage Δ
sdmetrics/reports/utils.py 94.65% <ø> (-4.24%) ⬇️
...rts/single_table/_properties/column_pair_trends.py 87.63% <80.00%> (+0.06%) ⬆️
...trics/reports/single_table/_properties/coverage.py 86.84% <86.84%> (ø)
...rics/reports/single_table/_properties/synthesis.py 97.14% <97.14%> (ø)
sdmetrics/reports/multi_table/_properties/base.py 98.03% <97.22%> (-1.97%) ⬇️
...ics/reports/multi_table/base_multi_table_report.py 97.50% <97.50%> (ø)
sdmetrics/reports/_results_handler.py 97.67% <97.67%> (ø)
...trics/reports/single_table/_properties/boundary.py 97.91% <97.91%> (ø)
sdmetrics/reports/base_report.py 98.78% <98.78%> (ø)
sdmetrics/errors.py 100.00% <100.00%> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24 and others added 8 commits August 25, 2023 15:51
* Ensure that the Synthesis property score doesn't change

* adding integration tests
#438)

* Adding class to handle printing of report results

* Updating unit tests to match refactored code

* Adding integration test for multiple generate calls

* fixing lint

* renaming test files to match actual files

* making single_table.property details public
* Fix np.nan shown in results

* Fix lint

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment