Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot column pair utility method #224

Merged
merged 3 commits into from Sep 14, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Sep 13, 2022

Resolves #223

@katxiao katxiao requested a review from a team as a code owner September 13, 2022 17:51
@katxiao katxiao requested review from fealho and removed request for a team September 13, 2022 17:51
@katxiao katxiao force-pushed the issue-223-column-pair-utility-method branch from 118b579 to 8ef1024 Compare September 13, 2022 21:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Base: 69.56% // Head: 70.18% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (405340b) compared to base (4a79665).
Patch coverage: 96.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   69.56%   70.18%   +0.61%     
==========================================
  Files          70       70              
  Lines        2425     2482      +57     
==========================================
+ Hits         1687     1742      +55     
- Misses        738      740       +2     
Impacted Files Coverage Δ
sdmetrics/reports/utils.py 97.98% <96.61%> (-0.93%) ⬇️
sdmetrics/reports/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@katxiao katxiao force-pushed the issue-223-column-pair-utility-method branch from 8ef1024 to 77d446b Compare September 14, 2022 00:07
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Left a couple of minor comments, good to go otherwise ⚡

sdmetrics/reports/utils.py Outdated Show resolved Hide resolved
sdmetrics/reports/utils.py Outdated Show resolved Hide resolved
tests/unit/reports/test_utils.py Outdated Show resolved Hide resolved
tests/unit/reports/test_utils.py Outdated Show resolved Hide resolved
@katxiao katxiao merged commit 62e6b73 into master Sep 14, 2022
@katxiao katxiao deleted the issue-223-column-pair-utility-method branch September 14, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add get_column_pairs_plot utility method
3 participants