Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_column_plot #455

Merged
merged 4 commits into from Sep 27, 2023
Merged

Add get_column_plot #455

merged 4 commits into from Sep 27, 2023

Conversation

pvk-developer
Copy link
Member

Resolves #443

image image image image

@pvk-developer pvk-developer requested a review from a team as a code owner September 25, 2023 09:36
@pvk-developer pvk-developer requested review from rwedge and removed request for a team September 25, 2023 09:36
@pvk-developer pvk-developer requested review from amontanez24 and frances-h and removed request for rwedge September 25, 2023 09:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023 •
edited

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.04% ⚠️

Comparison is base (efeb278) 76.54% compared to head (6fa8b31) 76.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   76.54%   76.50%   -0.04%     
==========================================
  Files          92       92              
  Lines        3359     3358       -1     
==========================================
- Hits         2571     2569       -2     
- Misses        788      789       +1
Files Changed Coverage Δ
sdmetrics/reports/utils.py 93.15% <ø> (-0.72%) ⬇️
sdmetrics/visualization.py 91.95% <89.65%> (+1.04%) ⬆️
sdmetrics/reports/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frances-h
frances-h approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for catching that nan bug.

amontanez24
amontanez24 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments but after that 🚢

sdmetrics/visualization.py Outdated Show resolved Hide resolved
sdmetrics/visualization.py Outdated Show resolved Hide resolved
@amontanez24
Copy link
Contributor

also can we rename the PR to get instead of generate

@pvk-developer pvk-developer changed the title Add generate_column_plot Add get_column_plot Sep 27, 2023
@pvk-developer pvk-developer merged commit f80dc79 into main Sep 27, 2023
45 checks passed
@pvk-developer pvk-developer deleted the issue-443-add-new-get_column_plot branch September 27, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@frances-h frances-h frances-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new get_column_plot
4 participants
@pvk-developer @codecov-commenter @amontanez24 @frances-h