Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 addons that pass on our code #83

Closed
wants to merge 6 commits into from

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 4, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #83 (cf8df82) into master (d38e1ff) will decrease coverage by 22.76%.
The diff coverage is 51.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #83       +/-   ##
===========================================
- Coverage   73.93%   51.16%   -22.77%     
===========================================
  Files          21       50       +29     
  Lines         468     1503     +1035     
===========================================
+ Hits          346      769      +423     
- Misses        122      734      +612     
Impacted Files Coverage Δ
sdmetrics/single_table/efficacy/mlefficacy.py 0.00% <0.00%> (ø)
sdmetrics/timeseries/ml_scorers.py 19.04% <19.04%> (ø)
sdmetrics/single_table/gaussian_mixture.py 26.47% <26.47%> (ø)
sdmetrics/__init__.py 42.85% <29.41%> (-57.15%) ⬇️
...cs/single_table/privacy/radius_nearest_neighbor.py 31.25% <31.25%> (ø)
sdmetrics/single_table/privacy/base.py 32.53% <32.53%> (ø)
sdmetrics/single_table/base.py 35.89% <35.89%> (ø)
sdmetrics/single_table/privacy/loss.py 39.13% <39.13%> (ø)
sdmetrics/single_table/efficacy/base.py 40.00% <40.00%> (ø)
sdmetrics/timeseries/efficacy/base.py 41.30% <41.30%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b76df9...cf8df82. Read the comment docs.

@fealho fealho force-pushed the issue-80-add-flake8-that-passes branch from a010f1e to e8b9196 Compare November 4, 2021 17:48
@fealho fealho marked this pull request as ready for review November 4, 2021 17:50
@fealho fealho requested a review from a team as a code owner November 4, 2021 17:50
@fealho fealho requested review from pvk-developer and removed request for a team November 4, 2021 17:50
@fealho fealho closed this Nov 4, 2021
@fealho fealho removed the request for review from pvk-developer November 4, 2021 21:40
@fealho fealho deleted the issue-80-add-flake8-that-passes branch November 4, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants