Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review unittests #111

Closed
JDTheRipperPC opened this issue Sep 4, 2019 · 0 comments · Fixed by #113
Closed

Review unittests #111

JDTheRipperPC opened this issue Sep 4, 2019 · 0 comments · Fixed by #113
Assignees
@JDTheRipperPC
Labels
internal The issue doesn't change the API or functionality
Milestone
0.2.0

Comments

@JDTheRipperPC
Copy link
Contributor

Review unittests, have no test that requires external data.
@JDTheRipperPC JDTheRipperPC added the internal The issue doesn't change the API or functionality label Sep 4, 2019
@JDTheRipperPC JDTheRipperPC self-assigned this Sep 4, 2019
@JDTheRipperPC JDTheRipperPC mentioned this issue Sep 9, 2019
Merged
@csala csala added this to the 0.1.3 milestone Sep 17, 2019
@csala csala added the approved label Sep 18, 2019
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this issue Feb 7, 2022
@fealho @leix28 @csala
V0.3.0 (sdv-dev#112)
0359bb4 
* relative import; warning filter; data sampler file

* merge cond sampler and sampler to one data sampler

* change code to 2 space indent

* define util classes and rename variables.

* refactoring transformer and fix bugs.

* rename file

* rename func

* add hyper parameters to args.

* add doc strings.

* fix line length

* fix bug

* fix indent

* change indent to 4

* we should allow breaking lines before binary operators.

* Bump version: 0.2.2.dev1 → 0.3.0.dev0

* Code refactoring

* Removes attr and load/save, and fix lint

* Fix typo

* Fix conda version

* Add TVAE (sdv-dev#111)

* Adds tvae

* Correctly adds tvae

* Restructure files

* Simplify tvae test

* Fix lint/add verbose to ctgan

* Fix lint

* Move epochs from fit to __init__

* Fix epochs relocation

* General refactoring

* Fix readme

* Adds save/laod to base class

* Fixes save/load, adds test case

* Fix lint

* Fix lint

* Improved testing

* Added FutureWarning

* Updated warning/fix lint

* Fixes tvae bug/fix lint

* Empty commit

* Fix lint

* Update readme

* Updates readme

* Updates readme

Co-authored-by: Lei Xu <leix@mit.edu>
Co-authored-by: Carles Sala <carles@pythiac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDTheRipperPC JDTheRipperPC

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Issue 111 review unittests sdv-dev/SDV
2 participants
@csala @JDTheRipperPC